-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webpack-env] add import.meta.webpackContext
for webpack 5.70.0+
#59414
Conversation
import.meta.webpackContext
for 5.70.0+import.meta.webpackContext
for webpack 5.70.0+
@Rhilip Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59414,
"author": "Rhilip",
"headCommitOid": "80a955d46fd89948a292930eb6b0a7473917f967",
"mergeBaseOid": "1e570c25a40b6ee4161618af4e0212a64e00ae9d",
"lastPushDate": "2022-03-23T14:43:54.000Z",
"lastActivityDate": "2022-04-15T11:05:58.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2022-04-14T03:48:39.000Z",
"mergeRequestDate": "2022-04-15T11:05:58.000Z",
"mergeRequestUser": "Rhilip",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "webpack-env",
"kind": "edit",
"files": [
{
"path": "types/webpack-env/index.d.ts",
"kind": "definition"
},
{
"path": "types/webpack-env/webpack-env-tests.ts",
"kind": "test"
}
],
"owners": [
"use-strict",
"rhonsby"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2022-04-14T03:47:57.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1076454170,
"ciResult": "pass"
} |
🔔 @use-strict @rhonsby — please review this PR in the next few days. Be sure to explicitly select |
Please confirm the version in the header doesn't need to be bumped. |
LGTM, but I'd like to hear from an owner. |
Re-ping @use-strict, @rhonsby: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @Rhilip. (Ping @use-strict, @rhonsby.) |
@Rhilip: Everything looks good here. I am ready to merge this PR (at 80a955d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@use-strict, @rhonsby: you can do this too.) |
Ready to merge |
Webpack 5.70.0+ provide a new function
import.meta.webpackContext
, see:this pr extends interface
ImportMeta
in@types/webpack-env
and addwebpackContext
functionPlease fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "@definitelytyped/dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
If removing a declaration:
notNeededPackages.json
.